-
Notifications
You must be signed in to change notification settings - Fork 7
Check copyright header with opengrep #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check copyright header with opengrep #78
Conversation
|
I have strong suspicion that running opengrep is still not stable |
d077dcc to
09a6ba0
Compare
09a6ba0 to
ceb6820
Compare
|
We currently have this bazel/python/crazy-mix script for copyright. We should be using reuse. I'm not so sure adding another tool to the mix is a good idea. |
To me it looks quite heavy to introduce bazel just for this to this repo. bazel will likely never be used here to build anything |
I think as well... using Bazel to build devcontainers is really not a good idea. |
There you can see how the same with bazel would look like: elektrobit-contrib#2 However I have to quote a very wise man
|
|
#79 is the same with bazel instead of opengrep |
|
I wasn't proposing to add bazel, oh my god 😆 I guess we'll use |
👍 |
| # Limit concurrency to 2 threads to reduce memory consumption | ||
| OPENGREP_MAX_CONCURRENCY="--jobs=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: 2 or 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be an artifact from yesterdays build instabilities I was fighting. Since we want to try https://git.fsfe.org/reuse/reuse-tool I would leave it as is for the time being.
The devcontainer lacks so far copyright headers and SPDX lines. With pre-commit hooks and opengrep these can be automatically enforced.
Fixes #68